Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify biblatex entry type form #7494

Merged
merged 5 commits into from
Mar 5, 2021
Merged

Simplify biblatex entry type form #7494

merged 5 commits into from
Mar 5, 2021

Conversation

tmrd993
Copy link
Contributor

@tmrd993 tmrd993 commented Mar 5, 2021

Fixes #6730
Related PR: #7485
This is a follow-up PR that simplifies the select entry type form in biblatex mode.

Screenshots:
entryFormNonExpand

Expanded:
entryFormExpand

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

calixtus
calixtus approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 😅

@calixtus
Copy link
Member

calixtus commented Mar 5, 2021

Don't forget the changelog.

@mlep
Copy link
Contributor

mlep commented Mar 5, 2021

Don't forget the changelog.

Since this is a follow-up, I guess the line included in the changelog is enough ("We simplified the select entry type form by splitting it into two parts ("Recommended" and "Others") based on internal usage data. #6730")

@Siedlerchr Siedlerchr merged commit f7de0a6 into JabRef:master Mar 5, 2021
@Siedlerchr
Copy link
Member

Thanks for the quick follow up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User interface: Simplify Select Entry type form
4 participants
@tmrd993 @calixtus @mlep @Siedlerchr